don't use multiline string for browser auth #23

2023-06-22T20:44:57+02:00

Yagich commented

2023-06-22 20:44:57 +02:00

(Migrated from github.com)

currently, if the user tries to authenticate with Gift.authenticate(), the browser will open a malformed URL and return a 404 because the URL string contains multiple lines and indentation:

	OS.shell_open("https://id.twitch.tv/oauth2/authorize
	?response_type=code
	&client_id=" + client_id +
	"&redirect_uri=http://localhost:18297
	&scope=" + scope)

this PR fixes it by not using a multiline string. it's not the prettiest to be on one line, so if you'd like a better way to do it while keeping it free of tab characters and newlines i'm open to suggestions 🙂

currently, if the user tries to authenticate with `Gift.authenticate()`, the browser will open a malformed URL and return a 404 because the URL string contains multiple lines and indentation: ```gdscript OS.shell_open("https://id.twitch.tv/oauth2/authorize ?response_type=code &client_id=" + client_id + "&redirect_uri=http://localhost:18297 &scope=" + scope) ``` this PR fixes it by not using a multiline string. it's not the prettiest to be on one line, so if you'd like a better way to do it while keeping it free of tab characters and newlines i'm open to suggestions 🙂

issork commented

2023-06-23 06:03:04 +02:00

(Migrated from github.com)

Thanks! ^^

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: issork/gift#23