issork/gift
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

Dictionary key error if invalid secret is used after successful login #35

New Issue
Closed
opened 2023-11-14 13:37:16 +01:00 by JFurness1 · 3 comments
JFurness1 commented 2023-11-14 13:37:16 +01:00 (Migrated from github.com)
Copy Link

I had GIFT up and running. Great add-on, thanks for all your work!

I accidentally committed my secret to my repo (despite making an auth file to avoid that 😒) so I created a new secret at dev.twitch.tv and updated the secret in the auth file.

Now attempting to connect I receive a 403: Invalid client secret response and the add-on crashes at line 174 in gift_node.gd.

image

I had GIFT up and running. Great add-on, thanks for all your work! I accidentally committed my secret to my repo (despite making an auth file to avoid that 😒) so I created a new secret at dev.twitch.tv and updated the secret in the auth file. Now attempting to connect I receive a `403: Invalid client secret` response and the add-on crashes at line `174` in `gift_node.gd`. ![image](https://github.com/issork/gift/assets/6610047/311a3ed2-6a0a-49ad-b353-8c953bd692f8)
issork commented 2023-11-14 13:41:38 +01:00 (Migrated from github.com)
Copy Link

Try deleting the file located at user://gift/auth/user_token and let me know if that fixes it - will fix this problem in a future update if it does.

Try deleting the file located at `user://gift/auth/user_token` and let me know if that fixes it - will fix this problem in a future update if it does.
JFurness1 commented 2023-11-18 23:02:34 +01:00 (Migrated from github.com)
Copy Link

No fix from that.

I think the problem is that when the 403 is returned the token dictionary has only two entries, neither of which is "access token".

No fix from that. I think the problem is that when the 403 is returned the token dictionary has only two entries, neither of which is `"access token"`.
❤️ 1
issork commented 2023-12-02 20:48:33 +01:00 (Migrated from github.com)
Copy Link

This should now be solved with the rewrite.

PS: Also no more accidentally pushing client secrets since the Implicit Grant Flow is now supported. Now you can comfortably ship your games with your client_id included in the exported project and users no longer have to create their own apps through the developer console.

This should now be solved with the rewrite. PS: Also no more accidentally pushing client secrets since the Implicit Grant Flow is now supported. Now you can comfortably ship your games with your client_id included in the exported project and users no longer have to create their own apps through the developer console.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
Godot 4.0
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
issork
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: issork/gift#35
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?