Broken Asset Store addon #33

Closed
opened 2023-10-21 05:50:33 +02:00 by JD-The-65th · 8 comments
JD-The-65th commented 2023-10-21 05:50:33 +02:00 (Migrated from github.com)

Hey,
I'm trying to use this addon in my 4.2beta2 project but it seems to be broken.

I've set the auth file in my project file to be formatted like required, and I even put all of the info inside of the gift.gd script itself, but it seems to be broken, at least on my Steam Deck, where it just opens a "404 page not found" link to https://id.twitch.tv/oauth2/authorize/everythingelse

My application's OAuth Redirect URL is set to http://localhost

Hey, I'm trying to use this addon in my 4.2beta2 project but it seems to be broken. I've set the auth file in my project file to be formatted like required, and I even put all of the info inside of the gift.gd script itself, but it seems to be broken, at least on my Steam Deck, where it just opens a "404 page not found" link to https://id.twitch.tv/oauth2/authorize/`everythingelse` My application's OAuth Redirect URL is set to http://localhost
mrTag commented 2023-10-23 18:52:52 +02:00 (Migrated from github.com)

Your redirect URL seems to be missing the port. It has to be set exactly to http://localhost:18297
I just had a superfluous / at the end of the URL and it didn't work.

Your redirect URL seems to be missing the port. It has to be set exactly to `http://localhost:18297` I just had a superfluous `/` at the end of the URL and it didn't work.
JD-The-65th commented 2023-10-23 22:13:40 +02:00 (Migrated from github.com)

Weird, I'm gonna try this when I get back home

Weird, I'm gonna try this when I get back home
JD-The-65th commented 2023-10-25 00:18:29 +02:00 (Migrated from github.com)

I've set my oauth redirect url to be "http://localhost:18297" but it still doesn't work. It doesn't look like it's sending the client secret, so I'm going to send the link it generates.

https://id.twitch.tv/oauth2/authorize%0A%09?response_type=code%0A%09&client_id=c1vdqvcpqtv5gzohx07cgaydytoa9i&redirect_uri=http://localhost:18297%0A%09&scope=chat%3Aedit%20chat%3Aread

I've set my oauth redirect url to be "http://localhost:18297" but it still doesn't work. It doesn't look like it's sending the client secret, so I'm going to send the link it generates. https://id.twitch.tv/oauth2/authorize%0A%09?response_type=code%0A%09&client_id=c1vdqvcpqtv5gzohx07cgaydytoa9i&redirect_uri=http://localhost:18297%0A%09&scope=chat%3Aedit%20chat%3Aread
mrTag commented 2023-10-25 10:39:23 +02:00 (Migrated from github.com)

The URL has weird %0A%09 characters in them. I just tried removing them from your link and tada: a twitch authentication window pops up! Looks like this: https://id.twitch.tv/oauth2/authorize?response_type=code&client_id=c1vdqvcpqtv5gzohx07cgaydytoa9i&redirect_uri=http://localhost:18297&scope=chat%3Aedit%20chat%3Aread

I also tried an online URL decoder to see what the %0A%09 decodes to and it is a newline followed by a tab. Did you somehow mess with the URL generation code? That is how that line should look like:
204928ad5c/addons/gift/gift_node.gd (L188)

The URL has weird `%0A%09` characters in them. I just tried removing them from your link and tada: a twitch authentication window pops up! Looks like this: https://id.twitch.tv/oauth2/authorize?response_type=code&client_id=c1vdqvcpqtv5gzohx07cgaydytoa9i&redirect_uri=http://localhost:18297&scope=chat%3Aedit%20chat%3Aread I also tried an online URL decoder to see what the %0A%09 decodes to and it is a newline followed by a tab. Did you somehow mess with the URL generation code? That is how that line should look like: https://github.com/issork/gift/blob/204928ad5c319b22f62c44ca361811cfe13e357c/addons/gift/gift_node.gd#L188
JD-The-65th commented 2023-10-25 14:12:19 +02:00 (Migrated from github.com)

I didn't mess with the URL generation code. I got this addon off of the Godot Asset store, so maybe that has something to do with it. I'm gonna try to replace the line in my script with that line.

I didn't mess with the URL generation code. I got this addon off of the Godot Asset store, so maybe that has something to do with it. I'm gonna try to replace the line in my script with that line.
JD-The-65th commented 2023-10-25 14:32:56 +02:00 (Migrated from github.com)

Somehow, the line got split up in the Addon Store version of this plugin... Weird.
OS.shell_open("https://id.twitch.tv/oauth2/authorize ?response_type=code &client_id=" + client_id + "&redirect_uri=http://localhost:18297 &scope=" + scope)

Somehow, the line got split up in the Addon Store version of this plugin... Weird. `OS.shell_open("https://id.twitch.tv/oauth2/authorize ?response_type=code &client_id=" + client_id + "&redirect_uri=http://localhost:18297 &scope=" + scope)`
JD-The-65th commented 2023-10-25 18:07:18 +02:00 (Migrated from github.com)

Forgot to respond, it works perfectly after replacing the line in the local script with the line above. Somehow, the asset store version has that line split.

Forgot to respond, it works perfectly after replacing the line in the local script with the line above. Somehow, the asset store version has that line split.
issork commented 2023-10-25 18:08:56 +02:00 (Migrated from github.com)

Oh, I too forgot to respond. This was fixed in #23, but I seem to have forgotten to release it to the asset store, thanks!

Oh, I too forgot to respond. This was fixed in #23, but I seem to have forgotten to release it to the asset store, thanks!
Sign in to join this conversation.
No description provided.